search

puppetlabs / puppet-specifications

Specification of the Puppet Language, Catalog, Extension points
Other
99 stars 66 forks source link

(PE-12458) File path changes for PE client tools #58

Closed jdwelch closed 8 years ago

jdwelch commented 8 years ago

Update to the file_path.md file to capture recent additions for PE client tools

MosesMendoza commented 8 years ago

+1

jdwelch commented 8 years ago

Can one of @shrug @MosesMendoza merge this if you're happy with it?

shrug commented 8 years ago

ping @joshcooper @kylog Do y'all have any input here? I'll merge otherwise

kylog commented 8 years ago

:+1:

joshcooper commented 8 years ago

LGTM. One side note, the directory C:\ProgramData\PuppetLabs\client-tools is writable by all users, and the MSI should restrict permissions on that directory as it will presumably contain passwords, etc, e.g. https://github.com/puppetlabs/puppet_for_the_win/blob/master/wix/puppet.wxs#L296-L301. It's not hard to do, but we need to make sure that happens. /cc @Iristyle