search

puppetlabs / puppet-strings

The next generation Puppet documentation extraction and presentation tool.
http://puppetlabs.github.io/puppet-strings/
Apache License 2.0
90 stars 84 forks source link

Fix acceptance tests #306

Closed danielparks closed 2 years ago

danielparks commented 2 years ago

Previously, acceptance tests were failing during the initial installation of fixtures:

Cloning into 'spec/fixtures/modules/puppet_agent'... fatal: unable to connect to github.com: github.com[0: 140.82.113.4]: errno=Connection timed out

This switches to using https URLs for the fixtures, which allows acceptance tests to proceed beyond that point.

I don’t normally use Docker, so it’s hard for me to tell what’s problem on my machine and what’s a problem with the acceptance testing setup. I’m getting errors while spinning up the CentOS container:

Failure connecting to localhost:52595: {"target"=>"localhost:52595", "action"=>"command", "object"=>nil, "status"=>"failure", "value"=>{"_error"=>{"details"=>{}, "kind"=>"puppetlabs.tasks/connect-error", "msg"=>"Failed to connect to localhost:52595: pkeys are immutable on OpenSSL 3.0", "issue_code"=>"CONNECT_ERROR"}}}

danielparks commented 2 years ago

Looks like those errors are on my end, since they succeed in Travis. I also took the opportunity to add the new (?) location of the Litmus inventory file to .gitignore.

chelnak commented 2 years ago

This fix is spot on. Thank you.