Add deprecated tag - Githubissues

puppetlabs / puppet-strings

The next generation Puppet documentation extraction and presentation tool.

http://puppetlabs.github.io/puppet-strings/

Apache License 2.0

90 stars 84 forks source link

Closed b4ldr closed 1 year ago

b4ldr commented 1 year ago

I had a stab at adding the deprecated flag

Fixes #339

chelnak commented 1 year ago

This looks good and tests are passing.

Just one thing I noticed that we can maybe tidy up.

The description being used for deprecated is "Use a something else".

Could you possibly change the message a bit so it's more relevant to the deprecation of something and a little softer?

Maybe along the lines of "no longer supported and will be removed in a future release".

Thanks!

b4ldr commented 1 year ago

thanks for the comments

Maybe along the lines of "no longer supported and will be removed in a future release". done

chelnak commented 1 year ago

Looks like you have a couple of rubocop violations to clear up.

Once they are done I'm happy to get this merged!

b4ldr commented 1 year ago

updated hopefully all green now

chelnak commented 1 year ago

@b4ldr Thank you!