search

puppetlabs / puppet-strings

The next generation Puppet documentation extraction and presentation tool.
http://puppetlabs.github.io/puppet-strings/
Apache License 2.0
90 stars 84 forks source link

(maint) - fix rubocop #360

Closed jordanbreen28 closed 1 year ago

jordanbreen28 commented 1 year ago

https://msp-greg.github.io/rubocop/RuboCop/Cop/Style/ArgumentsForwarding.html

donoghuc commented 11 months ago

@jordanbreen28 @GSPatton I do not believe this is strictly a ruby 2.7 compatible feature. This gem claims support for ruby 2.7 and delegation (...) is not supported with leading arguments in for example ruby 2.7.0 https://scriptday.com/blog/2020/09/12/ruby-3-0-added-leading-arguments-forwarding I think we need to revert this in order to maintain ruby 2.7 compatibility (i would expect breaking ruby compatability to be a major version bump in semver).