search

puppetlabs / puppet-strings

The next generation Puppet documentation extraction and presentation tool.
http://puppetlabs.github.io/puppet-strings/
Apache License 2.0
90 stars 84 forks source link

(maint) Fix rubocop lint warnings #374

Closed gavindidrichsen closed 11 months ago

gavindidrichsen commented 11 months ago

Summary

Fix failing nightly CI rubocop warnings:

➜  puppet-strings git:(maint_fix_rubocop_warnings) bundle exec rubocop --format github

::error file=lib/puppet-strings/describe.rb,line=69,col=44::Layout/ExtraSpacing: Unnecessary spacing detected.
::error file=lib/puppet-strings/yard/code_objects/function.rb,line=11,col=11::Lint/SymbolConversion: Unnecessary symbol conversion; use `:"puppet_functions_#{type}"` instead.
::error file=lib/puppet-strings/yard/code_objects/provider.rb,line=11,col=11::Lint/SymbolConversion: Unnecessary symbol conversion; use `:"puppet_providers_#{type}"` instead.
::error file=lib/puppet-strings/yard/code_objects/type.rb,line=172,col=36::Lint/SymbolConversion: Unnecessary symbol conversion; use `:"puppet_providers_#{name}"` instead.
::error file=lib/puppet-strings/yard/util.rb,line=38,col=23::Style/RedundantParentheses: Don't use parentheses around a logical expression.
➜  puppet-strings git:(maint_fix_rubocop_warnings)

Checklist