Closed ZloeSabo closed 3 years ago
Merging #430 (ebd020c) into main (1a2b075) will increase coverage by
0.23%
. The diff coverage isn/a
.:exclamation: Current head ebd020c differs from pull request most recent head d253bb2. Consider uploading reports for the commit d253bb2 to get more accurate results
@@ Coverage Diff @@
## main #430 +/- ##
==========================================
+ Coverage 62.42% 62.65% +0.23%
==========================================
Files 7 7
Lines 865 865
==========================================
+ Hits 540 542 +2
+ Misses 325 323 -2
Impacted Files | Coverage Δ | |
---|---|---|
lib/puppet_litmus/rake_helper.rb | 74.14% <0.00%> (+0.76%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1a2b075...d253bb2. Read the comment docs.
Hi @ZloeSabo, the images described in the matrix_from_metadata are used to generate the setup test matrix we use across the IAC supported modules. As you probably seen on most of our modules we use actual VMs to run tests for RHEL, Windows and SLES images - example run. The containers we spin up are managed by the DOCKER_PLATFORMS definition in this file where possible.
I've removed the RedHat-7/8 support from the code as the non-namespaced
rhel-7
andrhel-8
images are no longer available on the docker hub and I wasn't able to find any functioning alternatives to replace them.I've tried the official UBI images, but currently
puppetlabs/provision
does not have support forrhel
distro that UBI reports. And even if I fork it and add it, RedHat objects adding OpenSSH server to their repos for UBI, so litmus won't be able to connect there. As for the non-UBI images, I didn't find one that is both maintained and has systemd set up properly so that they could run services.Without this change, litmus fails with something like
I would gladly update this PR if someone points me at images that I can use instead.