puppetlabs / puppet_litmus

Providing a simple command line tool for puppet content creators, to enable simple and complex test deployments.
Apache License 2.0
88 stars 55 forks source link

Remove support for rhel docker images that no longer exist #430

Closed ZloeSabo closed 3 years ago

ZloeSabo commented 3 years ago

I've removed the RedHat-7/8 support from the code as the non-namespaced rhel-7 and rhel-8 images are no longer available on the docker hub and I wasn't able to find any functioning alternatives to replace them.

I've tried the official UBI images, but currently puppetlabs/provision does not have support for rhel distro that UBI reports. And even if I fork it and add it, RedHat objects adding OpenSSH server to their repos for UBI, so litmus won't be able to connect there. As for the non-UBI images, I didn't find one that is both maintained and has systemd set up properly so that they could run services.

Without this change, litmus fails with something like

localhost: {"_error"=>{"kind"=>"provision/docker_failure", "msg"=>"Attempted to run\ncommand:'docker run -d -it --privileged  --tmpfs /tmp:exec -p 2222:22 --name rhel-7-2222 rhel-7'\nstdout:\nstderr:Unable to find image 'rhel-7:latest' locally\ndocker: Error response from daemon: pull access denied for rhel-7, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.\nSee 'docker run --help'.\n", "backtrace"=>["/tmp/4d3453a8-0565-43e7-80a1-c9923604b48d/provision/lib/task_helper.rb:21:in `run_local_command'", "/tmp/4d3453a8-0565-43e7-80a1-c9923604b48d/provision/tasks/docker.rb:156:in `provision'", "/tmp/4d3453a8-0565-43e7-80a1-c9923604b48d/provision/tasks/docker.rb:198:in `<main>'"], "details"=>{}}}}

I would gladly update this PR if someone points me at images that I can use instead.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

codecov-commenter commented 3 years ago

Codecov Report

Merging #430 (ebd020c) into main (1a2b075) will increase coverage by 0.23%. The diff coverage is n/a.

:exclamation: Current head ebd020c differs from pull request most recent head d253bb2. Consider uploading reports for the commit d253bb2 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
+ Coverage   62.42%   62.65%   +0.23%     
==========================================
  Files           7        7              
  Lines         865      865              
==========================================
+ Hits          540      542       +2     
+ Misses        325      323       -2     
Impacted Files Coverage Δ
lib/puppet_litmus/rake_helper.rb 74.14% <0.00%> (+0.76%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a2b075...d253bb2. Read the comment docs.

carabasdaniel commented 3 years ago

Hi @ZloeSabo, the images described in the matrix_from_metadata are used to generate the setup test matrix we use across the IAC supported modules. As you probably seen on most of our modules we use actual VMs to run tests for RHEL, Windows and SLES images - example run. The containers we spin up are managed by the DOCKER_PLATFORMS definition in this file where possible.