search

puppetlabs / puppet_litmus

Providing a simple command line tool for puppet content creators, to enable simple and complex test deployments.
Apache License 2.0
88 stars 55 forks source link

(MAINT) Remove Windows Server 2012R2 #462

Closed chelnak closed 1 year ago

chelnak commented 1 year ago

Agent installation has been failing on Windows Server 2012R2 for some time now.

It turns out that this is being caused by a mismatch in ciphers between the provisioned boxes and the service that provides nightlies.puppet.com.

The nightlies archive requires a specific set of ciphers which are not supported on the base installs of Server 2012 R2.

This commit removes Server 2012 R2 from the list of images that are used to build the test matrix.

codecov-commenter commented 1 year ago

Codecov Report

Base: 64.66% // Head: 64.44% // Decreases project coverage by -0.21% :warning:

Coverage data is based on head (8bd1169) compared to base (8db22fd). Patch has no changes to coverable lines.

:exclamation: Current head 8bd1169 differs from pull request most recent head 148ea93. Consider uploading reports for the commit 148ea93 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #462 +/- ## ========================================== - Coverage 64.66% 64.44% -0.22% ========================================== Files 7 7 Lines 917 917 ========================================== - Hits 593 591 -2 - Misses 324 326 +2 ``` | [Impacted Files](https://codecov.io/gh/puppetlabs/puppet_litmus/pull/462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=puppetlabs) | Coverage Δ | | |---|---|---| | [lib/puppet\_litmus/rake\_helper.rb](https://codecov.io/gh/puppetlabs/puppet_litmus/pull/462/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=puppetlabs#diff-bGliL3B1cHBldF9saXRtdXMvcmFrZV9oZWxwZXIucmI=) | `73.38% <0.00%> (-0.77%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=puppetlabs). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=puppetlabs)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

david22swan commented 1 year ago

Technically this would be backwards incompatible. But since this is still a 0. release module we can set it as a bugfix.