search

puppetlabs / puppet_litmus

Providing a simple command line tool for puppet content creators, to enable simple and complex test deployments.
Apache License 2.0
89 stars 56 forks source link

(CAT-1688) - Pin rubocop to `~> 1.50.0` #541

Closed LukasAud closed 10 months ago

LukasAud commented 10 months ago

Following a recent team decision, we are implementing a Rubocop Upgrade moving the version from 1.48.1 to 1.50.0. This should be the final version until Puppet 7 is unsupported.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 64 lines in your changes are missing coverage. Please review.

Comparison is base (8db22fd) 64.66% compared to head (703a172) 61.64%. Report is 159 commits behind head on main.

Files Patch % Lines
lib/puppet_litmus/puppet_helpers.rb 77.02% 34 Missing :warning:
lib/puppet_litmus/rake_tasks.rb 15.00% 17 Missing :warning:
lib/puppet_litmus/rake_helper.rb 85.52% 11 Missing :warning:
lib/puppet_litmus/inventory_manipulation.rb 85.71% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #541 +/- ## ========================================== - Coverage 64.66% 61.64% -3.02% ========================================== Files 7 6 -1 Lines 917 764 -153 ========================================== - Hits 593 471 -122 + Misses 324 293 -31 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.