puppetlabs / puppetdb

Centralized Puppet Storage
http://docs.puppetlabs.com/puppetdb
Apache License 2.0
299 stars 225 forks source link

Remove duplicate storage of catalgo resource parameters #3923

Closed austb closed 8 months ago

austb commented 9 months ago

Currently resource parameters are stored flattened in resource_params and as jsonb in resource_params_cache. Both of these tables are deduplicated and contain all the parameter information. Most queries are already backed by resource_params_cache. A few summary queries, and the completely undocumented select_params, which is only valid as a subquery, use the resource_params table still.

Internal issue: https://perforce.atlassian.net/browse/PE-37294

austb commented 8 months ago

For now, this does not seem to be a worthwhile improvment so it will not be done. See the PR comment https://github.com/puppetlabs/puppetdb/pull/3922#issuecomment-1871414608 for more details