search

puppetlabs / puppetlabs-apt

Puppet module to help manage Apt
https://forge.puppetlabs.com/puppetlabs/apt
Apache License 2.0
215 stars 463 forks source link

Omit empty options in source.list template to fix MODULES-11174 #1013

Closed mpdude closed 2 years ago

mpdude commented 2 years ago

Empty [name= ...] options in a soures list lead to Apt parsing errors.

This change skips such empty options, resolving https://tickets.puppetlabs.com/browse/MODULES-11174.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

mpdude commented 2 years ago

Probably the issue was introduced in #991 and is because of a misbehaviour of delete_undef_values in Puppet 6.

As per https://tickets.puppetlabs.com/browse/MODULES-7835, this has been fixed in puppetlabs/stdlib 5.1.0, so upgrading to at least that version might also resolve the issue.