search

puppetlabs / puppetlabs-apt

Puppet module to help manage Apt
https://forge.puppetlabs.com/puppetlabs/apt
Apache License 2.0
215 stars 462 forks source link

Allow to configure environment variables for apt-get update command. #1047

Closed findmyname666 closed 1 year ago

findmyname666 commented 1 year ago

Hello all,

We are using custom APT transport for an internal mirror. However our transport is configurable via environment variables. In current state no ENV vars are available for update command. This PR introduce argument option $::apt::update['environment'] to configure required ENV variables for APT update command.

BR

puppet-community-rangefinder[bot] commented 1 year ago

apt::params is a class

that may have no external impact to Forge modules.

apt::update is a class

Breaking changes to this file WILL impact these 17 modules (exact match): * [bltavares-baseline](https://github.com/bltavares/vagrant-baseline) * [hfm-h2o](https://github.com/hfm/puppet-h2o) * [narasimhasv-lxc](https://forge.puppet.com/narasimhasv/lxc) * [narasimhasv-docker](https://forge.puppet.com/narasimhasv/docker) * [locp-odoo9](https://github.com/locp/puppet-odoo) * [praekeltfoundation-gluster](https://github.com/praekeltfoundation/puppet-gluster) * [praekeltfoundation-xylem](https://github.com/praekeltfoundation/puppet-xylem) * [locp-odoo](https://github.com/locp/puppet-odoo) * [praekeltfoundation-consular](https://github.com/praekeltfoundation/puppet-consular) * [hfm-percona](https://github.com/hfm/puppet-percona) * [wavesoftware-xtreemfs](https://github.com/wavesoftware/puppet-xtreemfs.git) * [poolski-beats](https://github.com/poolski/puppet-beats) * [midonet-cassandra](https://github.com/midonet/puppet-cassandra) * [puppet-cassandra](https://github.com/voxpupuli/puppet-cassandra) * [locp-opscenter](https://github.com/locp/opscenter) * [midonet-midonet](https://github.com/midonet/puppet-midonet) * [locp-cassandra](https://github.com/locp/cassandra)
Breaking changes to this file MAY impact these 9 modules (near match): * [factorit-icingaweb2](https://github.com/Icinga/puppet-icingaweb2.git) * [hfm-octopass](https://github.com/hfm/puppet-octopass) * [meltwater-marathon](https://github.com/meltwater/puppet-marathon) * [hfm-proxysql](https://github.com/hfm/puppet-proxysql) * [jtopjian-cubbystack](https://github.com/jtopjian/puppet-cubbystack) * [narasimhasv-openstack](https://forge.puppet.com/narasimhasv/openstack) * [hfm-tinyproxy](https://github.com/hfm/puppet-tinyproxy) * [hfm-stns](https://github.com/STNS/puppet-stns) * [puppetlabs-openstack](https://github.com/puppetlabs/puppetlabs-openstack.git)

This module is declared in 234 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

puppet-community-rangefinder[bot] commented 1 year ago

apt::params is a class

that may have no external impact to Forge modules.

apt::update is a class

Breaking changes to this file WILL impact these 17 modules (exact match): * [bltavares-baseline](https://github.com/bltavares/vagrant-baseline) * [hfm-h2o](https://github.com/hfm/puppet-h2o) * [narasimhasv-lxc](https://forge.puppet.com/narasimhasv/lxc) * [narasimhasv-docker](https://forge.puppet.com/narasimhasv/docker) * [locp-odoo9](https://github.com/locp/puppet-odoo) * [praekeltfoundation-gluster](https://github.com/praekeltfoundation/puppet-gluster) * [praekeltfoundation-xylem](https://github.com/praekeltfoundation/puppet-xylem) * [locp-odoo](https://github.com/locp/puppet-odoo) * [praekeltfoundation-consular](https://github.com/praekeltfoundation/puppet-consular) * [hfm-percona](https://github.com/hfm/puppet-percona) * [wavesoftware-xtreemfs](https://github.com/wavesoftware/puppet-xtreemfs.git) * [poolski-beats](https://github.com/poolski/puppet-beats) * [midonet-cassandra](https://github.com/midonet/puppet-cassandra) * [puppet-cassandra](https://github.com/voxpupuli/puppet-cassandra) * [locp-opscenter](https://github.com/locp/opscenter) * [midonet-midonet](https://github.com/midonet/puppet-midonet) * [locp-cassandra](https://github.com/locp/cassandra)
Breaking changes to this file MAY impact these 9 modules (near match): * [factorit-icingaweb2](https://github.com/Icinga/puppet-icingaweb2.git) * [hfm-octopass](https://github.com/hfm/puppet-octopass) * [meltwater-marathon](https://github.com/meltwater/puppet-marathon) * [hfm-proxysql](https://github.com/hfm/puppet-proxysql) * [jtopjian-cubbystack](https://github.com/jtopjian/puppet-cubbystack) * [narasimhasv-openstack](https://forge.puppet.com/narasimhasv/openstack) * [hfm-tinyproxy](https://github.com/hfm/puppet-tinyproxy) * [hfm-stns](https://github.com/STNS/puppet-stns) * [puppetlabs-openstack](https://github.com/puppetlabs/puppetlabs-openstack.git)

This module is declared in 234 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

findmyname666 commented 1 year ago

Any good soul who can take a look on this simple PR ?

chelnak commented 1 year ago

Hey @findmyname666 , thank you!

Can you add a spec test to account for this new parameter?

jordanbreen28 commented 1 year ago

Hi @findmyname666 - just hoping to check if there has been any progress on adding a spec test for this new functionality? Additionally, there are some conflicts that will need resolved before we can proceed. Thanks :-)

jordanbreen28 commented 1 year ago

Hi @findmyname666! We are reviewing some of our ageing PRs, and as there has been no movement on this since August 16th, it's suggested that we close this request. If you have the time to pick this back up again in the near future and address the comments above - please do re-open this PR! (Or create a new one)

Thanks for all your work on this!