(GH-cat-9) Update module to match current syntax standard

[david22swan]

Module is now in compliance with the following rules:

• optional_default
• strict_indent
• unquoted_string_in_case
• parameter_documentation
• relative_classname_inclusion
• no-top_scope_facts-check
• no-top_scope_variable-check
• variable_scope

The below exception has been left in place:

• disable_anchor_resource

[puppet-community-rangefinder[bot]]

apt::pin is a type

Breaking changes to this file WILL impact these 32 modules (exact match):

* [prachetasp-rabbitmq](https://github.com/prachetasp/puppetlabs-rabbitmq.git) * [mpiscaer-dnsdist](https://github.com/mpiscaer/puppet_dnsdist) * [flatline235-aptsimplesoftware](https://github.com/flat235/puppet-aptsimplesoftware.git) * [lightoze-puppetrepo](https://github.com/lightoze/puppet-puppetrepo) * [dowlingw-nvidia](https://github.com/dowlingw/puppet-nvidia) * [norisnetwork-ceph](https://github.com/noris-network/puppet-ceph) * [icann-knot](https://github.com/icann-dns/puppet-knot) * [abaranov-wireguard](https://github.com/spacedog/puppet-wirguard) * [msimonin-cassandra](https://github.com/msimonin/puppet-cassandra) * [puppet-erlang](https://github.com/voxpupuli/puppet-erlang) * [vshn-uhosting](https://github.com/vshn/uhosting) * [hetzner-roundcube](https://github.com/hetznerZA/hetzner-roundcube.git) * [oxc-rspamd](https://github.com/oxc/puppet-rspamd) * [spjmurray-puppet](https://github.com/spjmurray/puppet-puppet) * [sensson-powerdns](https://github.com/sensson/puppet-powerdns) * [godp1301-postgresql](https://github.com/godp1301/puppetlabs-postgresql.git) * [spjmurray-ceph](https://github.com/spjmurray/puppet-ceph) * [smash-tor](https://gitlab.com/shared-puppet-modules-group/tor) * [simp-postgresql](https://github.com/simp/puppetlabs-postgresql.git) * [puppetlabs-docker](https://github.com/puppetlabs/puppetlabs-docker) * [memoussati-postgresql](https://github.com/puppetlabs/puppetlabs-postgresql.git) * [memoussati-docker](https://github.com/garethr/garethr-docker.git) * [mvasilenko-docker](https://github.com/mvasilenko/garethr-docker.git) * [puppetlabs-rabbitmq](https://github.com/puppetlabs/puppetlabs-rabbitmq) * [vshn-gitlab](https://github.com/vshn/puppet-gitlab) * [covata-safeshare](https://bitbucket.org/covata/puppet_covata_services) * [hackerhappyhour-docker](https://github.com/HackerHappyHour/hackerhappyhour-docker.git) * [librato-librato](https://github.com/librato/puppet-librato) * [cesnet-site_hadoop](https://github.com/MetaCenterCloudPuppet/cesnet-site_hadoop) * [ape-elasticsearch](https://github.com/pecharmin/puppet-elasticsearch) * [elasticsearch-elasticsearch](https://github.com/elastic/puppet-elasticsearch) * [codingfuture-cfsystem](https://github.com/codingfuture/puppet-cfsystem)

Breaking changes to this file MAY impact these 10 modules (near match):

* [puppet-rabbitmq](https://github.com/voxpupuli/puppet-rabbitmq) * [tedivm-hieratic](https://github.com/tedivm/puppet-hieratic) * [ceritsc-perun](https://github.com/CERIT-SC/puppet-perun.git) * [ploperations-nginx](https://github.com/puppetlabs-operations/puppet-nginx) * [puppetfinland-postgresql](https://github.com/Puppet-Finland/puppet-postgresql.git) * [camptocamp-qgis](https://github.com/camptocamp/puppet-qgis) * [eyp-nrpe](https://github.com/NTTCom-MS/eyp-nrpe) * [echoes-wrappers](https://github.com/echoes-tech/puppet-wrappers) * [soli-wrappers](https://github.com/solution-libre/puppet-wrappers) * [codingfuture-cfdb](https://github.com/codingfuture/puppet-cfdb)

This module is declared in 234 of 579 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[jensk]

This changeset introduces a warning which breaks an important part of the update manifest

Warning: Unknown variable: 'apt::apt_update_last_success'. (file: /usr/local/puppet/vendor/apt/manifests/update.pp, line: 22, column: 12)

[kenyon]

@jensk that should have been fixed in #1081.