search

puppetlabs / puppetlabs-apt

Puppet module to help manage Apt
https://forge.puppetlabs.com/puppetlabs/apt
Apache License 2.0
215 stars 462 forks source link

Updated mark as title can contain dot (fixes #1074) #1075

Closed xepa closed 1 year ago

xepa commented 1 year ago

ubuntu packages can contain dots in the name, like: containerd.io

puppet-community-rangefinder[bot] commented 1 year ago

apt::mark is a type

that may have no external impact to Forge modules.

This module is declared in 235 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

LukasAud commented 1 year ago

Hi @xepa, sorry for the delay in feedback. It looks like your bugfix is not passing some of our unit tests. This needs to be addressed before we can merge your PR.

xepa commented 1 year ago

Hi @xepa, sorry for the delay in feedback. It looks like your bugfix is not passing some of our unit tests. This needs to be addressed before we can merge your PR.

Ah I noticed also .. seems that there are some tests that use invalid debian package names and they are expected to succeed .. (for instance the tests assume that my_source is a valid package name according to the manual its not valid)

xepa commented 1 year ago

Hi @LukasAud I reread the policy and found some edge cases not covered before (updated regex again) and updated the unit tests, they should now all pass.