search

puppetlabs / puppetlabs-apt

Puppet module to help manage Apt
https://forge.puppetlabs.com/puppetlabs/apt
Apache License 2.0
215 stars 462 forks source link

fix: remove `apt::` prefix from fact variables #1081

Closed johanfleury closed 1 year ago

johanfleury commented 1 year ago

Fact variables are top-scopped and should not be prefixed by module name.

This bug was introduced by cb6e58cedbd6d7a9bfc63c97c83d51eb39e9c7dc.

puppet-community-rangefinder[bot] commented 1 year ago

apt::update is a class

Breaking changes to this file WILL impact these 17 modules (exact match): * [locp-cassandra](https://github.com/locp/cassandra) * [midonet-midonet](https://github.com/midonet/puppet-midonet) * [puppet-cassandra](https://github.com/voxpupuli/puppet-cassandra) * [midonet-cassandra](https://github.com/midonet/puppet-cassandra) * [hfm-percona](https://github.com/hfm/puppet-percona) * [locp-opscenter](https://github.com/locp/opscenter) * [praekeltfoundation-xylem](https://github.com/praekeltfoundation/puppet-xylem) * [praekeltfoundation-gluster](https://github.com/praekeltfoundation/puppet-gluster) * [praekeltfoundation-consular](https://github.com/praekeltfoundation/puppet-consular) * [poolski-beats](https://github.com/poolski/puppet-beats) * [bltavares-baseline](https://github.com/bltavares/vagrant-baseline) * [wavesoftware-xtreemfs](https://github.com/wavesoftware/puppet-xtreemfs.git) * [narasimhasv-docker](https://forge.puppet.com/narasimhasv/docker) * [narasimhasv-lxc](https://forge.puppet.com/narasimhasv/lxc) * [locp-odoo](https://github.com/locp/puppet-odoo) * [locp-odoo9](https://github.com/locp/puppet-odoo) * [hfm-h2o](https://github.com/hfm/puppet-h2o)
Breaking changes to this file MAY impact these 9 modules (near match): * [hfm-stns](https://github.com/STNS/puppet-stns) * [puppetlabs-openstack](https://github.com/puppetlabs/puppetlabs-openstack.git) * [meltwater-marathon](https://github.com/meltwater/puppet-marathon) * [hfm-tinyproxy](https://github.com/hfm/puppet-tinyproxy) * [jtopjian-cubbystack](https://github.com/jtopjian/puppet-cubbystack) * [hfm-proxysql](https://github.com/hfm/puppet-proxysql) * [narasimhasv-openstack](https://forge.puppet.com/narasimhasv/openstack) * [factorit-icingaweb2](https://github.com/Icinga/puppet-icingaweb2.git) * [hfm-octopass](https://github.com/hfm/puppet-octopass)

This module is declared in 235 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

johanfleury commented 1 year ago

@pmcmaw I’m pinging you as you’re the one who published the previous release: once this PR is merged, could you please make a new release as soon as possible?

Release v9.0.1 is broken with: Server Error: Evaluation Error: Unknown variable: 'apt::apt_update_last_success'. (file: /etc/puppetlabs/code/environments/production/modules/apt/manifests/update.pp, line: 21, column: 10).

johanfleury commented 1 year ago

@kenyon thanks for the review, your suggestions make sense. Let me know if there’s anything else I should change.