puppetlabs / puppetlabs-apt

Puppet module to help manage Apt
https://forge.puppetlabs.com/puppetlabs/apt
Apache License 2.0
215 stars 462 forks source link

(CONT-493) PPA validation adjustment #1085

Closed LukasAud closed 1 year ago

LukasAud commented 1 year ago

Prior to this commit, one of our updates (https://github.com/puppetlabs/puppetlabs-apt/pull/1052) implemented a regex validation for ppa packages that were to be installed. However, this validation did not account for resource names that were dotted.

This commit aims to fix this bug in our validation process so that it works as intended. This PR should fix https://github.com/puppetlabs/puppetlabs-apt/issues/1084.

puppet-community-rangefinder[bot] commented 1 year ago

apt::ppa is a type

Breaking changes to this file WILL impact these 68 modules (exact match): * [garethr-golang](https://github.com/garethr/garethr-golang.git) * [aageyev-redis](https://bitbucket.org/aageyev/redis) * [monkygames-nvidia](https://bitbucket.org/monkygames/puppet-nvidia) * [darkmantle-java](https://github.com/darkmantle/puppet-java) * [jcalles-php](https://github.com/mayflower/puppet-php) * [cmantix-nginxphp](https://bitbucket.org/hfraser/puppet-nginx-php) * [meeh-java](https://github.com/meeh420/puppet-java.git) * [petems-cockpit](https://github.com/petems/petems-cockpit) * [a2tar-redis](https://github.com/a2tar/redis.git) * [garethr-pypy](https://github.com/garethr/garethr-pypy.git) * [rehan-git](https://github.com/rehanone/puppet-git.git) * [cesnet-java_ng](https://github.com/MetaCenterCloudPuppet/cesnet-java_ng) * [bltavares-baseline](https://github.com/bltavares/vagrant-baseline) * [csanchez-ninjablocks](http://github.com/carlossg/puppet-ninjablocks) * [puppet-rsyslog](https://github.com/voxpupuli/puppet-rsyslog) * [factorit-jasperreports_server](https://github.com/jbbrunsveld/jasperreports_server) * [CraigWatson1987-transmission](https://github.com/craigwatson/puppet-transmission.git) * [spantree-java8](https://github.com/Spantree/puppet-java8.git) * [spantree-java7](https://github.com/Spantree/puppet-java7.git) * [wemakecustom-composer](https://github.com/wemakecustom/puppet-composer.git) * [signalfx-collectd](https://github.com/signalfx/puppet_collectd) * [a2tar-nodejs](https://github.com/a2tar/puppet_nodejs.git) * [opstudio-duplicity](https://git.opstudio.pro/modules/duplicity.git) * [m3del-sabnzbd](https://github.com/nctiggy/m3del-sabnzbd) * [monkygames-landscape](https://bitbucket.org/monkygames/puppet-landscape.git) * [puppet-php](https://github.com/voxpupuli/puppet-php) * [ngiger-x2go](https://forge.puppet.com/ngiger/x2go) * [CraigWatson1987-bitcoind](https://github.com/craigwatson/puppet-transmission.git) * [Aethylred-ck](https://github.com/Aethylred/puppet-ck) * [cpick-hub](https://github.com/cpick/puppet-hub.git) * [praekeltfoundation-consular](https://github.com/praekeltfoundation/puppet-consular) * [TubeMogul-druid](https://github.com/tubemogul/puppet-druid.git) * [puppet-facette](https://github.com/voxpupuli/puppet-facette.git) * [abaranov-wireguard](https://github.com/spacedog/puppet-wirguard) * [edestecd-software](https://github.com/edestecd/puppet-software.git) * [aageyev-nodejs](https://bitbucket.org/aageyev/nodejs) * [guimaluf-gvpe](https://github.com/guimaluf/puppet-gvpe) * [johnlawerance-crucible](https://github.com/johnlawerance/crucible.git) * [arioch-redis](https://github.com/arioch/puppet-redis) * [dowlingw-nvidia](https://github.com/dowlingw/puppet-nvidia) * [praekeltfoundation-webupd8_oracle_java](https://github.com/praekeltfoundation/puppet-webupd8_oracle_java) * [nrvale0-keepass2](https://github.com/nrvale0/puppet-keepass2) * [adcade-java7](https://forge.puppet.com/adcade/java7) * [tracywebtech-java](https://github.com/TracyWebTech/puppet-java) * [a2labs-nginx](https://aageyev@bitbucket.org/a2labs/nginx.git) * [mayflower-php](https://github.com/mayflower/puppet-php) * [elithrar-golang](https://github.com/elithrar/puppet-golang-backports.git) * [ncorrare-yubikey](https://github.com/ncorrare/ncorrare-yubikey) * [garethr-rustlang](https://github.com/garethr/garethr-rustlang.git) * [igovua-nodejs](https://bitbucket.org/egovinfrastructure/puppet_module_nodejs.git) * [praekeltfoundation-gluster](https://github.com/praekeltfoundation/puppet-gluster) * [dsestero-java](https://github.com/dsestero/java.git) * [rfletcher-ec2_consistent_snapshot](https://forge.puppet.com/rfletcher/ec2_consistent_snapshot) * [garethr-mirageos](https://github.com/garethr/garethr-mirageos.git) * [devsec-suricata](https://github.com/odinje/puppet-suricata) * [driebit-zotonic](https://github.com/driebit/puppet-zotonic.git) * [shoekstra-owncloud](https://github.com/shoekstra/puppet-owncloud.git) * [andschwa-mumble](https://github.com/andschwa/puppet-mumble.git) * [tsuru-base](https://github.com/tsuru/puppet-tsuru) * [tsuru-tsuru](https://github.com/tsuru/puppet-tsuru) * [dowlingw-kodi](https://github.com/dowlingw/puppet-kodi) * [abstractit-icinga](https://github.com/abstractitptyltd/abstractit-icinga) * [rehan-nginx](https://github.com/rehanone/puppet-nginx.git) * [puppet-mumble](https://github.com/voxpupuli/puppet-mumble.git) * [badquanta-badstation](https://github.com/BadQuanta/badquanta-badstation) * [rendhalver-icinga](https://forge.puppet.com/rendhalver/icinga) * [justintw-develop_environment](https://github.com/JustinTW/justintw-develop_environment) * [justintw-developer_environment](https://github.com/JustinTW/justintw-developer_environment)
Breaking changes to this file MAY impact these 10 modules (near match): * [eyp-nrpe](https://github.com/NTTCom-MS/eyp-nrpe) * [camptocamp-fprint](https://github.com/camptocamp/puppet-fprint) * [opendaylight-opendaylight](https://git.opendaylight.org/gerrit/p/integration/packaging/puppet-opendaylight.git) * [puppet-redis](https://github.com/voxpupuli/puppet-redis.git) * [belskiiartem-logcourier](https://github.com/belskiiartem/logcourier.git) * [tedivm-hieratic](https://github.com/tedivm/puppet-hieratic) * [puppet-borg](https://github.com/voxpupuli/puppet-borg.git) * [hackerhorse-puppet_deluge](https://github.com/RainbowHackerHorse/puppet_deluge) * [nibalizer-zfs](https://github.com/nibalizer/puppet-module-zfs.git) * [eyp-php](https://github.com/NTTCom-MS/eyp-php)

This module is declared in 235 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.