search

puppetlabs / puppetlabs-apt

Puppet module to help manage Apt
https://forge.puppetlabs.com/puppetlabs/apt
Apache License 2.0
215 stars 462 forks source link

Adopt new parameter defaults in template #1090

Closed tuxmea closed 1 year ago

tuxmea commented 1 year ago

the apt::pin define has switched from empty string to Undef. But the template was not updated.

fixes #1089

chelnak commented 1 year ago

I wonder if undef is the right default to set here?

I know there were conversations around this yesterday.. interested in your thoughts.

tuxmea commented 1 year ago

I wonder if undef is the right default to set here?

I know there were conversations around this yesterday.. interested in your thoughts.

Hi @chelnak I just adopted the template to the new parameter defaults. Usually we use undef on optional parameters. But I am open to also revert the parameter defaults to empty string.

tuxmea commented 1 year ago

Hi @chelnak can we continue with this PR? This really is an issue where people use the apt::pin type.

chelnak commented 1 year ago

Hey sure, sorry about the wait.

I went over your changes again and am happy.