puppetlabs / puppetlabs-apt

Puppet module to help manage Apt
https://forge.puppetlabs.com/puppetlabs/apt
Apache License 2.0
216 stars 462 forks source link

Another validation of ppa issue #1097

Open ghost opened 1 year ago

ghost commented 1 year ago

Describe the Bug

In #1084 the validation was already updated once, now I apparently have found another special case: ppa:c2d4u.team/c2d4u4.0+.

Expected Behavior

The ppa should be used correctly and should not fail the validation.

Steps to Reproduce

Steps to reproduce the behavior:

apt::ppa { 'ppa:c2d4u.team/c2d4u4.0+':
  ensure => present,
}

Results in:

Evaluation Error: Error while evaluating a Function Call, Invalid PPA name: ppa:c2d4u.team/c2d4u4.0+

Environment

Additional Context

The minimal change might be my hotfix, but maybe there is a more general solution to this problem.

-  if $name !~ /^ppa:([a-zA-Z0-9\-_.]+)\/([a-zA-z0-9\-_\.]+)$/ {
+  if $name !~ /^ppa:([a-zA-Z0-9\-_.]+)\/([a-zA-z0-9\-_\.\+]+)$/ {

Thank you for the great puppet module 🙇🏼