search

puppetlabs / puppetlabs-apt

Puppet module to help manage Apt
https://forge.puppetlabs.com/puppetlabs/apt
Apache License 2.0
215 stars 462 forks source link

W: --force-yes is deprecated, use one of the options starting with --allow instead. #1130

Closed XSpielinbox closed 1 year ago

XSpielinbox commented 1 year ago

Describe the Bug

Puppet calls apt-get with the --force-yes option. This option has been deprecated and replaced by --allow-unauthenticated, --allow-downgrades, --allow-remove-essential and --allow-change-held-packages in apt 1.1 in 2015.

Expected Behavior

The Puppet apt module does not use --force-yes.

Steps to Reproduce

Steps to reproduce the behavior:

  1. run puppet agent -t on a node that then has to downgrade a package.

Environment

Additional Context

For enhanced backwards compatibility one might have an option that users that really need it, can explicitly enable to use the old --force-yes option.

kenyon commented 1 year ago

The only place I see --force-yes in this module is here, which is in the acceptance tests, not in code that Puppet would run: https://github.com/puppetlabs/puppetlabs-apt/blob/a6db503562693ed622b2aec7ca1afb21a1ce5668/spec/acceptance/apt_spec.rb#L51

I think you want to file this bug against puppet itself, not this apt module: https://github.com/search?q=repo%3Apuppetlabs%2Fpuppet%20--force-yes&type=code

XSpielinbox commented 1 year ago

Ok, thank you. Unfortunately, I cannot file an issue there as Issues are disabled for that GitHub repo and all links to the Jira Issue tracker are dead too...

Ramesh7 commented 1 year ago

Thanks @XSpielinbox for raising and sorry for inconvenience, looks the README.md file still points to the old JIRA URL. I have created tracker ticket internally to update to new JIRA ticket. Will update once this activity is done. Thanks again.

Also will review the module where ever there is --force-yes is get used, and do needful baed on the outcome.

Ramesh7 commented 1 year ago

Have reviewed the module and as @kenyon mentioned we only have --force-yes in spec file otherwise we are not using this anymore. I will also use this issue to fix that part as long run. Thanks @kenyon for being on top of this.

Ramesh7 commented 1 year ago

Closing this as we have fixed in repo, the same will review for other modules and do needful, Thanks Team!!

XSpielinbox commented 1 year ago

Thank you @Ramesh7! Looking forward to getting this solved in puppet itself too.