search

puppetlabs / puppetlabs-apt

Puppet module to help manage Apt
https://forge.puppetlabs.com/puppetlabs/apt
Apache License 2.0
215 stars 462 forks source link

repos are mandatory, though they should not be #1132

Closed XSpielinbox closed 1 year ago

XSpielinbox commented 1 year ago

Describe the Bug

When looking at source.pp one can see that if one leaves out the repos definition or specifies undef, instead of not adding a component to the sources entry, main is added, resulting in problems when combined with and absolute suite. When I don't specify a repos (so a component), there shall not be a component. At least there should be an option to end the source definition after the release (so the distribution).

Expected Behavior

An apt source may only have a distribution (release in puppet) of / that is not followed by anything except a newline and I am able to easily replicate that with Puppet.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Try to add a source with [...] <url (location)> /

Environment

Additional Context

There is a workaround when specifying a repos of '', though that does not work in all cases. see #1133

Ramesh7 commented 1 year ago

Closing this as we have covered implementation in #1138