search

puppetlabs / puppetlabs-apt

Puppet module to help manage Apt
https://forge.puppetlabs.com/puppetlabs/apt
Apache License 2.0
216 stars 463 forks source link

Allow passing all `keyring` params in `apt::source` #1147

Closed kenyon closed 7 months ago

kenyon commented 7 months ago
kenyon commented 7 months ago

I'm intending to make use of this to modernize puppetlabs-puppet_agent in https://github.com/puppetlabs/puppetlabs-puppet_agent/blob/bd687442d8eaf9a08cb3f138f1e7a965c46f8490/manifests/osfamily/debian.pp

kenyon commented 7 months ago

@bastelfreak IMO these aren't backwards-incompatible changes since there hasn't been a release done with apt::keyring (#1128) yet.

kenyon commented 7 months ago

Ended up not needing this for https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/681, but I think these changes are good still.

bastelfreak commented 7 months ago

@kenyon oh right!