search

puppetlabs / puppetlabs-apt

Puppet module to help manage Apt
https://forge.puppetlabs.com/puppetlabs/apt
Apache License 2.0
215 stars 462 forks source link

Release prep v9.4.0 #1165

Closed github-actions[bot] closed 7 months ago

github-actions[bot] commented 7 months ago

Automated release-prep through pdk-templates from commit 1ed3a0858b95b431c9f8dfd27471035efcf3a031. Please verify before merging:

CLAassistant commented 7 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

GitHub Actions seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

bastelfreak commented 7 months ago

@malikparvez why did you run the release prep for 9.4.0? Now 9.3.0 is missing.

malikparvez commented 7 months ago

@malikparvez why did you run the release prep for 9.4.0? Now 9.3.0 is missing.

so the thing is our release workflow works by looking at the last merged PR which ideally should be release_prep but here 9.3.0 was created on Dec 16, 2023 so after merging this release was not working so for now I have deleted the 9.3.0 and reverted the PR and released 9.4.0

zilchms commented 7 months ago

It seems I cant follow you.

so the thing is our release workflow works by looking at the last merged PR which ideally should be release_prep

Very reasonable

but here 9.3.0 was created on Dec 16, 2023

That seems to be the creation data of the at that point unmerged PR, which was halted to get more PRs in and then rebased (and content-wise recreated). That should be fine right?

after merging this release was not working so for now I have deleted the 9.3.0 and reverted the PR and released 9.4.0

And here I am completely lost. So i guess the 9.3.0 release didnt work correctly? Therefore it was reverted and pulled. But then why are we not "reapplying" or opening a new 9.3.0 release (with release_prep etc) instead of directly going to 9.4.0.

I dont think there is anything to be done about it now. 9.3.0 doesnt exist, people have upgraded to 9.4.0. Was just wondering what went wrong :)