search

puppetlabs / puppetlabs-apt

Puppet module to help manage Apt
https://forge.puppetlabs.com/puppetlabs/apt
Apache License 2.0
215 stars 461 forks source link

MODULES-10543: only consider lsbdistcodename for apt-transport-https #905

Closed anarcat closed 4 years ago

anarcat commented 4 years ago

It does not matter if we have one older source from (say) jessie or stretch, we could still be running buster or later. The latter is more reliably indicated by the fact than by the provided "release" parameter, which is really just an arbitrary string that does not necessarily match a Debian suite, especially for third-party repositories.

I have had a problem with this setting when deploying a "stretch" repository on a "buster" system because I needed to keep MongoDB running (which is gone from buster). The "stretch" line triggered this line, which conflicted with a ensure_packages I had elsewhere in our code base, to remove the apt-transport-https package from buster and later.

An alternative implementation might prefer to remove the package unconditionnally if we run a newer release, but I figured I would keep the changes to a minimum.

codecov[bot] commented 4 years ago

Codecov Report

Merging #905 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #905   +/-   ##
=======================================
  Coverage   73.07%   73.07%           
=======================================
  Files           5        5           
  Lines         260      260           
=======================================
  Hits          190      190           
  Misses         70       70

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d5884ab...f862889. Read the comment docs.

geor-g commented 4 years ago

Thanks, LGTM.