search

puppetlabs / puppetlabs-apt

Puppet module to help manage Apt
https://forge.puppetlabs.com/puppetlabs/apt
Apache License 2.0
215 stars 461 forks source link

Parametrize file permissions #921

Closed carabasdaniel closed 4 years ago

carabasdaniel commented 4 years ago

Possible alternative to: https://github.com/puppetlabs/puppetlabs-apt/pull/920

codecov[bot] commented 4 years ago

Codecov Report

Merging #921 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #921   +/-   ##
=======================================
  Coverage   73.07%   73.07%           
=======================================
  Files           5        5           
  Lines         260      260           
=======================================
  Hits          190      190           
  Misses         70       70

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ed1706d...41347c1. Read the comment docs.

carabasdaniel commented 4 years ago

Hi @anarcat,

As we reverted file permissions in version 7.4.1 of the puppetlabs-apt module, I would like to know what is your opinion on exposing these values as parameters ?

anarcat commented 4 years ago

As we reverted file permissions in version 7.4.1 of the puppetlabs-apt module, I would like to know what is your opinion on exposing these values as parameters ?

Thanks for working on this, Daniel, and sorry my patch was badly received by some members of the community.

Seems like making those a parameter is a fine idea. Maybe we could just completely drop the mode parameter of those incantations? That way the proper defaults would play out, and site-specific File blocks would apply.

It seems to me that adding an extra parameter wouldn't be worth the trouble.

anarcat commented 4 years ago

@carabasdaniel i made #923 to show what i mean.

carabasdaniel commented 4 years ago

Closed this as #923 was merged