search

puppetlabs / puppetlabs-apt

Puppet module to help manage Apt
https://forge.puppetlabs.com/puppetlabs/apt
Apache License 2.0
215 stars 461 forks source link

(maint) Update apt custom facts #924

Closed gimmyxd closed 4 years ago

gimmyxd commented 4 years ago

This commit updates apt custom facts because the evaluation of custom facts code has changed between facter 2 and facter 4. In facter 2, when a custom fact is loaded, the code in add block was not executed. In facter 4, when a custom fact is loaded, the code outside setcode block is executed(same as Facter 3).

codecov[bot] commented 4 years ago

Codecov Report

Merging #924 into master will decrease coverage by 1.21%. The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #924      +/-   ##
==========================================
- Coverage   73.07%   71.86%   -1.22%     
==========================================
  Files           5        5              
  Lines         260      263       +3     
==========================================
- Hits          190      189       -1     
- Misses         70       74       +4
Impacted Files Coverage Δ
lib/facter/apt_updates.rb 85.24% <62.50%> (-4.41%) :arrow_down:
lib/facter/apt_reboot_required.rb 75.00% <0.00%> (-25.00%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 718cf4f...6786d50. Read the comment docs.