puppetlabs / puppetlabs-apt

Puppet module to help manage Apt
https://forge.puppetlabs.com/puppetlabs/apt
Apache License 2.0
215 stars 461 forks source link

Update to puppet-module-gems 1.0, pdk-templates and new rubocop #963

Closed DavidS closed 3 years ago

puppet-community-rangefinder[bot] commented 3 years ago

apt_key is a type

Breaking changes to this file MAY impact these 4 modules (near match): * [mmattice-apt](https://github.com/mmattice/puppetlabs-apt) * [lomignet-apt](https://github.com/lomignet/lomignet-apt) * [example42-apt](https://github.com/example42/puppet-apt) * [puppetlabs-apt](https://github.com/puppetlabs/puppetlabs-apt)

This module is declared in 233 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

codecov[bot] commented 3 years ago

Codecov Report

Merging #963 (406efe9) into main (a3b82bc) will not change coverage. The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #963   +/-   ##
=======================================
  Coverage   72.24%   72.24%           
=======================================
  Files           5        5           
  Lines         263      263           
=======================================
  Hits          190      190           
  Misses         73       73           
Impacted Files Coverage Δ
lib/facter/apt_reboot_required.rb 100.00% <ø> (ø)
lib/facter/apt_update_last_success.rb 85.71% <ø> (ø)
lib/puppet/provider/apt_key/apt_key.rb 54.81% <0.00%> (ø)
lib/puppet/type/apt_key.rb 96.42% <ø> (ø)
lib/facter/apt_updates.rb 85.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 139702c...406efe9. Read the comment docs.

kenyon commented 3 years ago

I think the testing section of CONTRIBUTING.md should also be updated if PDK is supposed to be used for testing.