(IAC-1597) Increasing MAX_RETRY_COUNT

puppetlabs / puppetlabs-apt

Puppet module to help manage Apt

https://forge.puppetlabs.com/puppetlabs/apt

Apache License 2.0

215 stars 461 forks source link

(IAC-1597) Increasing MAX_RETRY_COUNT #987

Closed pmcmaw closed 3 years ago

pmcmaw commented 3 years ago

Currently CI runs are seeing transient failures in testing on Ubuntu18 as the keyserver is not installed yet. This issue is consistent and this week has been seen on 2/5 nightlies. Bumping the MAx_RETRIES for Ubuntu18 to 10 to see if this resolves the issue.

This issue will be resolved when there are 5 nightly runs consecutively passing without the error being thrown.

Extended change to all OS as the same issue was seen on Debian 9.

pmcmaw commented 3 years ago

Unsure whether using a conditional to bump RETRIES on Ubuntu18 or bumping retries in general would be the best move here to avoid conditionals and complexity. Feedback from the reviewer would be much appreciated on this.

Disha-maker commented 3 years ago

Adding information on the errors seen on debian-9 for further investigation.

For the debian-9 under acceptance tests - this is the first error 
Error: /Stage[main]/Apt/Apt::Source[puppetlabs]/Apt::Key[Add key: 6F6B15509CF8E59E6E469F327F438280EF8D349F from Apt::Source puppetlabs]/Apt_key[Add key: 6F6B15509CF8E59E6E469F327F438280EF8D349F from Apt::Source puppetlabs]/ensure: change from 'absent' to 'present' failed: 

Execution of '/usr/bin/apt-key adv --no-tty --keyserver pool.sks-keyservers.net --recv-keys 6F6B15509CF8E59E6E469F327F438280EF8D349F' returned 2: Warning: apt-key output should not be parsed (stdout is not a terminal)

pmcmaw commented 3 years ago

The same issue has been seen over the weekend on Debian9 therefore making the decision to bump RETRIES for all OS.