search

puppetlabs / puppetlabs-azure_arm

The Puppet Azure ARM Module
Apache License 2.0
4 stars 16 forks source link

Eliminate obsolete parameter allow_pending_state for azure_server_farm_with_rich_sku; Fix dependencies for elastic_pool_name for azure_sql_database #16

Closed Monual closed 5 years ago

Monual commented 5 years ago

The provider "azure_server_farm_with_rich_sku" was requiring an obsolete parameter "allow_pending_state" despite the fact that such a parameter was not allowed for this type. Eliminating this parameter allows deploys to complete successfully.

Also, "azure_sql_database" was erroneously requiring "elastic_pool_name" and "recommended_pool_name", which are both optional parameters. It also failed trying to retrieve an ElasticPool when none existed. I removed both parameters from the "required" list and had the provider only check on ElasticPools if the elastic_pool_name or recommended_elastic_pool_name parameters were specified.

sheenaajay commented 5 years ago

@Monual Thanks for submitting the PR.Apologies for the bug delay in getting back to you. We are reviewing the code verifying the tests. Will keep you updated.Thanks again.

sheenaajay commented 5 years ago

@Monual All the changes are incorporated into the plugin. Will be doing the testing and regenerate the module and prepare for the release.Apologies for the delay.

sheenaajay commented 5 years ago

@Monual We have autogenerated the module and all your changes are in the master. For azure_sql_database provider, it was using incorrect operation-id and it's been fixed too. Please check and let us know. Thank you for your contribution.

sheenaajay commented 5 years ago

Released the azure_arm modules 0.2.2. with the changes.