puppetlabs / puppetlabs-concat

File concatenation system for Puppet
Apache License 2.0
171 stars 303 forks source link

(MODULES-3522) Removing redundant 'requires' #755

Closed LukasAud closed 1 year ago

LukasAud commented 1 year ago

Prior to this commit, there was an issue regarding the loading of the puppet/type/file/owner constant under certain circumstances during agent runs.

This commit aims to modernise the file request to comply with best practices.

puppet-community-rangefinder[bot] commented 1 year ago

concat_file is a type

Breaking changes to this file WILL impact these 1 modules (exact match): * [saz-ssh](https://github.com/saz/puppet-ssh.git)
Breaking changes to this file MAY impact these 2 modules (near match): * [puppet3-concat](https://github.com/puppet3/puppet3-concat) * [puppetlabs-concat](https://github.com/puppetlabs/puppetlabs-concat)

This module is declared in 169 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

canihavethisone commented 1 year ago

This change appears to have created issue as reported at https://github.com/puppetlabs/puppetlabs-concat/issues/758