search

puppetlabs / puppetlabs-concat

File concatenation system for Puppet
Apache License 2.0
171 stars 303 forks source link

Revert "(MODULES-3522) Removing redundant 'requires'" #759

Closed LukasAud closed 1 year ago

LukasAud commented 1 year ago

As established in #758, this update caused an unexpected regression. Reverts puppetlabs/puppetlabs-concat#755

puppet-community-rangefinder[bot] commented 1 year ago

concat_file is a type

Breaking changes to this file WILL impact these 1 modules (exact match): * [saz-ssh](https://github.com/saz/puppet-ssh.git)
Breaking changes to this file MAY impact these 2 modules (near match): * [puppet3-concat](https://github.com/puppet3/puppet3-concat) * [puppetlabs-concat](https://github.com/puppetlabs/puppetlabs-concat)

This module is declared in 169 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

chelnak commented 1 year ago

Thanks!

I'd be interested to know exactly why this happened and if it is something that we can test for?

canihavethisone commented 1 year ago

Thanks!

I'd be interested to know exactly why this happened and if it is something that we can test for?

@chelnak In this case running puppet generate types would have detected the issue. Is it worth adding that to acceptance tests? As I have recently learned, running that is standard in PE and best practice upon r10k deployments etc, so it should be catered for IMO

ekohl commented 1 year ago

I thought about the same thing, though I wonder if it should be an acceptance test or part of the unit test suite.