search

puppetlabs / puppetlabs-concat

File concatenation system for Puppet
Apache License 2.0
171 stars 303 forks source link

Revert "Correct Naming/AccessorMethodName" #777

Closed alexjfisher closed 1 year ago

alexjfisher commented 1 year ago

This reverts commit bc6478ae57ac25be6a53c8c64eca179853c3a598.

The API is sensitive_parameters, we can't just change the name of this method in this type because rubocop complains.

puppet-community-rangefinder[bot] commented 1 year ago

concat_fragment is a type

Breaking changes to this file WILL impact these 8 modules (exact match): * [simp-at](https://github.com/simp/pupmod-simp-at) * [simp-cron](https://github.com/simp/pupmod-simp-cron) * [southalc-podman](https://github.com/southalc/podman) * [example42-icinga](https://github.com/example42/puppet-icinga) * [simp-network](https://github.com/simp/pupmod-simp-network) * [simp-named](https://github.com/simp/pupmod-simp-named) * [saz-ssh](https://github.com/saz/puppet-ssh.git) * [example42-nagios](https://github.com/example42/puppet-nagios)
Breaking changes to this file MAY impact these 12 modules (near match): * [mcanevet-hostapd](https://github.com/mcanevet/puppet-hostapd) * [treydock-edac](https://github.com/treydock/puppet-edac.git) * [panaceya-dhcp](https://github.com/panaceya/puppet-dhcp) * [aswen-icinga](https://forge.puppet.com/aswen/icinga) * [zordrak-puppet](https://github.com/zordrak/puppet-puppet) * [simp-snmpd](https://github.com/simp/pupmod-simp-snmpd) * [simp-postgresql](https://github.com/simp/puppetlabs-postgresql.git) * [simp-openldap](https://github.com/simp/pupmod-simp-openldap) * [simp-ganglia](https://github.com/simp/pupmod-simp-ganglia) * [simp-nscd](https://github.com/simp/pupmod-simp-nscd) * [puppet3-concat](https://github.com/puppet3/puppet3-concat) * [puppetlabs-concat](https://github.com/puppetlabs/puppetlabs-concat)

This module is declared in 169 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

natemccurdy commented 1 year ago

Thanks for the fast turn around @alexjfisher

Though I wonder if there's an rspec test that could be added to catch a regression in expected behavior for the future.

I could try to add one later today when I find the time.