puppetlabs / puppetlabs-concat

File concatenation system for Puppet

Apache License 2.0

171 stars 303 forks source link

#775 - Explicitly resolve deferred values #789

Closed fetzerms closed 11 months ago

fetzerms commented 1 year ago

From Puppet Agent v8 onwards, a deferred value needs to be explicitly resolved.

Summary

This adds explicitly resolving of deferred values. See #775 If that fix is suitable (works for me), I'll be happy to add Spec and acceptance tests for deferred values.

Additional Context

I don't know of the root cause. Seems Puppet Agent v8 is doing things differently than <=v7

Related Issues (if any)

775

Checklist

[ ] 🟢 Spec tests.
[x] 🟢 Acceptance tests.
[x] Manually verified. (For example puppet apply)

CLAassistant commented 1 year ago

All committers have signed the CLA.

smortex commented 1 year ago

Failed unit tests seems transient. Closing and re-opening to trigger a new run.

fetzerms commented 1 year ago

@smortex - As the build is green now, do we think we can merge this? I think unit tests are not possible/required for this change. But if they are, I'm happy to be guided on what to test :-)

smortex commented 1 year ago

That seems good to me. There is no "policy" AFAIC for external contributors like me and other folks that where added as reviewers, but I would prefer to see a review/approval by someone from @puppetlabs since they own the project.