search

puppetlabs / puppetlabs-docker

The Puppet Docker repository
Apache License 2.0
91 stars 309 forks source link

Problem with docker_home_dirs fact #587

Closed oraziobattaglia closed 2 years ago

oraziobattaglia commented 4 years ago

What you expected to happen?

What happened?

Hello, I add the module to my infrasctructure and for each vm it populate the fact docker_home_dirs with all my AD user home. I use pbis-open on my vms and they are joined to an AD directory with thousand of accounts. So the docker_home_dirs fact becomes enourmous for each vm and that cause my puppet db to fail! Every vm report on puppet db had that very big fact.

I don't know if this is a bug or a feature, i only ask if there is a way i can disable the fact or if there is a better way to use it? I'm not a docker expert, i was just trying it!

Thank you for the time. Bye

How to reproduce it?

Anything else we need to know?

Versions:

$ puppet --version

$ docker version

$ facter os

$ puppet module list

Logs:

Paste any relevant logs from a puppet run
RamblingCookieMonster commented 3 years ago

No activity on this, but yeah, at a quick look, this is generating username->homedir for every single account in AD. In case it's unclear, this isn't exactly scalable if you have even a moderate sized AD. Curious to see what the intent of this is, and if it's not used, or is provided for the convenience of users, I would suggest making it optional, default to not populating it.

EDIT: This appears to be solved via https://github.com/puppetlabs/puppetlabs-docker/commit/86af7e3e51f8f8c941d2429715e854a015a0be22

github-actions[bot] commented 2 years ago

This issue has been marked as stale because it has been open for a while and has had no recent activity. If this issue is still important to you please drop a comment below and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.