puppetlabs / puppetlabs-docker

The Puppet Docker repository
Apache License 2.0
90 stars 308 forks source link

apt.dockerproject.org has been shut down #592

Closed mfuhrmann closed 2 years ago

mfuhrmann commented 4 years ago

Describe the Bug

The Docker module seems to provide the old repository which is not available since yesterday. The change was announced in February: https://www.docker.com/blog/changes-dockerproject-org-apt-yum-repositories/

W: The repository 'http://apt.dockerproject.org/repo ubuntu-xenial Release' does not have a Release file.
E: Failed to fetch http://apt.dockerproject.org/repo/dists/ubuntu-xenial/main/binary-i386/Packages  404  Not Found [IP: 13.224.194.62 80]

Expected Behavior

The module should use the current repository.

Environment

pier4r commented 4 years ago

+1

Although I think it is fixed: https://github.com/puppetlabs/puppetlabs-docker/blob/144c48476a526bf58140c4dce975d467e6c9f135/manifests/params.pp#L169-L171

mfuhrmann commented 4 years ago

For me it is not working yet.

Notice: /Stage[main]/Pe_basics::Software/Exec[apt-update]/returns: W: The repository 'http://apt.dockerproject.org/repo ubuntu-xenial Release' does not have a Release file.
Notice: /Stage[main]/Pe_basics::Software/Exec[apt-update]/returns: E: Failed to fetch http://apt.dockerproject.org/repo/dists/ubuntu-xenial/main/binary-amd64/Packages  404  Not Found [IP: 143.204.202.50 80]

Also there is no new release here: https://forge.puppet.com/puppetlabs/docker But maybe it takes a while, until it is published.

leoncard commented 4 years ago

Any news on that?

mfuhrmann commented 4 years ago

@leoncard We had to override the default settings in our Docker module like this to get it running again/less complaining...

    class { 'docker':
        version                   => $docker_version,
        docker_users              => $docker_users,
        docker_package_location   => "https://download.docker.com/linux/${os_lc}",
        docker_package_key_source => "https://download.docker.com/linux/${os_lc}/gpg",
        docker_package_key_id     => '9DC858229FC7DD38854AE2D88D81803C0EBFCD88',
        docker_package_release    => $lsbdistcodename,
    }
leoncard commented 4 years ago

@mfuhrmann thank you :)

nraval1729 commented 4 years ago

@mfuhrmann Thanks for the snippet 👍

kgeis commented 3 years ago

Not working for me using 4.0.0

github-actions[bot] commented 2 years ago

This issue has been marked as stale because it has been open for a while and has had no recent activity. If this issue is still important to you please drop a comment below and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.