search

puppetlabs / puppetlabs-docker

The Puppet Docker repository
Apache License 2.0
90 stars 304 forks source link

Docker module doesn't work in AmazonLinux2 #962

Open karthik-jaganathan opened 9 months ago

karthik-jaganathan commented 9 months ago

Describe the Bug

The Docker module is not working in AmazonLinux2 ARM hosts. There is a validation in the init.pp , it checks for RHEL >= 7. However, AmazonLinux2 VERSION has value of 2 so the above conditional check fails and module execution is exiting

NAME="Amazon Linux"
VERSION="2"
ID="amzn"
ID_LIKE="centos rhel fedora"
VERSION_ID="2"

Expected Behavior

Docker module should support all RHEL/Debian flaours

Steps to Reproduce

Steps to reproduce the behavior:

  1. Refer here for the validation https://github.com/puppetlabs/puppetlabs-docker/blob/fc069284a69e9cc7fcd8584578b1e91de0f364a7/manifests/init.pp#L479

Environment

Additional Context

Add any other context about the problem here.

rjd1 commented 5 months ago

Encountered the same issue recently and created a PR to address it. This change adds an exception to the RedHat 7 check for Amazon and another check below to fail if not Amazon Linux 2 or newer, effectively maintaining the same compatibility standard for that distribution.