puppetlabs / puppetlabs-docker

The Puppet Docker repository
Apache License 2.0
91 stars 311 forks source link

docker_stack incorrectly determines if the stack is deployed #968

Open gerases opened 9 months ago

gerases commented 9 months ago

Describe the Bug

When a stack runs on several machines and the services are spread out between them, this check in docker/lib/puppet/provider/docker_stack/ruby.rb doesn't work correctly:

      if stack_services.count != stack_containers.count
        return false
      end

Expected Behavior

Containers belonging to the same stack but running on other machines should be taken into account.

Additional Context

This code exists in version 4 of the module but also in the current version. I'm prepared to learn that I'm using the stack resource incorrectly for some reason.

akremer commented 8 months ago

Can confirm this bug exists.