search

puppetlabs / puppetlabs-docker

The Puppet Docker repository
Apache License 2.0
91 stars 311 forks source link

centos URL used for RedHat8, Rocky8, and Alma8 #998

Open jbagleyjr opened 2 months ago

jbagleyjr commented 2 months ago

Describe the Bug

Incorrect URL is used for the package_ce_source_location that includes "/centos/" which the docker stopped updating ~5 months ago.

Expected Behavior

Latest docker-ce package should be installed but were getting an older version because the incorrect repo URL is used.

Steps to Reproduce

Apply on any Rocky8, Alma8 or RedHat8. Docker version installed is 26 but should be 27.

Environment

Additional Context

Compare these two repos: https://download.docker.com/linux/rhel/8/x86_64/stable/Packages/ https://download.docker.com/linux/centos/8/x86_64/stable/Packages/

Seems like the rhel repo would be appropriate for our rocky and alma servers.

bastelfreak commented 2 months ago

Hi, I assume the problem is that CentOS 8 is EoL, so they don't update it anymore. For Rocky/Alma, they should use the rhel dir, not centos. Are you able to provide a PR for this?

jbagleyjr commented 2 months ago

Created pull request https://github.com/puppetlabs/puppetlabs-docker/pull/999 and am testing this fix in our environment.

jbagleyjr commented 2 months ago

confirmed the fix. We'll use my fork in our Puppetfile until the pull request is merged.