puppetlabs / puppetlabs-firewall

Puppet Firewall Module
http://forge.puppetlabs.com/puppetlabs/firewall
Apache License 2.0
275 stars 457 forks source link

Rule is not updated when source is removed #1241

Open limanzhang-ess opened 1 month ago

limanzhang-ess commented 1 month ago

Describe the Bug

When a rule is created with source, for example '006 accept HTTPS 443': chain: 'INPUT' state: "NEW" dport: '443' proto: tcp source: some_ip action: accept

Then source is removed: '006 accept HTTPS 443': chain: 'INPUT' state: "NEW" dport: '443' proto: tcp action: accept

The rule is not changed in iptables. It still holds the source and the module doesn't know the change.

Expected Behavior

Remove the source or destination in iptables when they are removed from puppet code.

Environment