search

puppetlabs / puppetlabs-java

Puppet Module to manage Java
https://forge.puppetlabs.com/puppetlabs/java
Apache License 2.0
102 stars 270 forks source link

facter error if no java is installed #538

Closed robertc99 closed 1 year ago

robertc99 commented 1 year ago

version 9.0.0 produces a facter error if the module is installed on a machine with no java installation. This happens even if the module isnt being called since its happening at fact resolution. The error is

Error: Facter: Error while resolving custom fact fact='java_version', resolution='': unexpected return

sircubbi commented 1 year ago

Same problem here. Rolled back to the old version for now.

jordanbreen28 commented 1 year ago

Thanks for raising this and bringing this to our attention @robertc99. If you visit the forge, a newer release of this module (v9.0.1) should have resolved this issue. I'll keep this issue open for a while to allow you to test this out. Thanks again.

xorpaul commented 1 year ago

I can confirm that the error disappears when using v9.0.1 Thanks @jordanbreen28 for solving it and @robertc99 for raising the issue.

sircubbi commented 1 year ago

I can confirm that the error disappears when using v9.0.1 Thanks @jordanbreen28 for solving it and @robertc99 for raising the issue.

Rolled out v9.0.1 here too, which solved the issue.

jordanbreen28 commented 1 year ago

Thank you for confirming @xorpaul & @sircubbi! In that case, I'll go ahead and close the issue.