puppetlabs / puppetlabs-kubernetes

This module install and configures a Kubernetes cluster
Apache License 2.0
92 stars 132 forks source link

Fix calico-tigera installation problems #639

Closed jorhett closed 9 months ago

jorhett commented 1 year ago

Update network preinstall and provider target URLs. Current ones return

Notice: /Stage[main]/Kubernetes::Kube_addons/Exec[Install cni network (preinstall)]/returns: error: unable to read URL "https://docs.projectcalico.org/manifests/tigera-operator.yaml", server reported 404 Not Found, status code=404
Error: '["kubectl", "apply", "-f", "https://docs.projectcalico.org/manifests/tigera-operator.yaml"]' returned 1 instead of one of [0]
Error: /Stage[main]/Kubernetes::Kube_addons/Exec[Install cni network (preinstall)]/returns: change from 'notrun' to ['0'] failed: '["kubectl", "apply", "-f", "https://docs.projectcalico.org/manifests/tigera-operator.yaml"]' returned 1 instead of one of [0]
Warning: Private key for 'test.foo.bar' does not exist
Warning: Client certificate for 'test.foo.bar' does not exist
Error: /Stage[main]/Kubernetes::Kube_addons/File[/etc/kubernetes/calico-installation.yaml]: Could not evaluate: Could not retrieve information from environment production source(s) https://docs.projectcalico.org/manifests/custom-resources.yaml

Found problem reported in projectcalico/calico#7300 Documentation now shows the raw URLs for the explicit version being used https://docs.tigera.io/calico/3.26/getting-started/kubernetes/quickstart#install-calico

Use kubectl create to avoid metadata length limitations

Sourced from upstream projectcalico/calico#6811 and docs at https://docs.tigera.io/calico/3.26/getting-started/kubernetes/quickstart#install-calico

jorhett commented 1 year ago

I overlooked that this overlaps with #617, should probably be combined.

jordanbreen28 commented 1 year ago

@jorhett some of this work was merged in with https://github.com/puppetlabs/puppetlabs-kubernetes/pull/625, are you able to refer to this, rebase and check if anything extra from your implementation is needed? Thanks for your work on this! 🚀

jordanbreen28 commented 1 year ago

did you get the chance to review the comment above @jorhett ?

jorhett commented 10 months ago

I've rebased from main as of today. All of the problems I originally reported remain unfixed so this PR remains valid.

deric commented 10 months ago

@jorhett Please, update the specs accordingly, e.g. apply -> create

jorhett commented 9 months ago

@deric should I assume you'll merge this when ready for the next release?