Ensure correct scheduler extra arguments passed to v1beta3 template

puppetlabs / puppetlabs-kubernetes

This module install and configures a Kubernetes cluster

Apache License 2.0

92 stars 135 forks source link

Closed treydock closed 10 months ago

treydock commented 10 months ago

The v1beta3 template needs to use correct argument to get the scheduler extra args.

I upgraded from 6.0.0 to 8.0.0 and lost some changes:

 scheduler:
-  extraArgs:
-    bind-address: 0.0.0.0

The Hiera I have is this:

kubernetes::scheduler_extra_arguments:
  - 'bind-address: 0.0.0.0'

Mention any related issues or pull requests.

CLAassistant commented 10 months ago

All committers have signed the CLA.

deric commented 10 months ago

Looks good, it would be nice to have some tests for this feature.

treydock commented 10 months ago

@deric I've added some unit tests

deric commented 10 months ago

@treydock Thanks, looks good. The centos failure seems to be unrelated.