search

puppetlabs / puppetlabs-kubernetes

This module install and configures a Kubernetes cluster
Apache License 2.0
92 stars 132 forks source link

Ensure correct scheduler extra arguments passed to v1beta3 template #670

Closed treydock closed 8 months ago

treydock commented 9 months ago

Summary

The v1beta3 template needs to use correct argument to get the scheduler extra args.

Additional Context

I upgraded from 6.0.0 to 8.0.0 and lost some changes:

 scheduler:
-  extraArgs:
-    bind-address: 0.0.0.0

The Hiera I have is this:

kubernetes::scheduler_extra_arguments:
  - 'bind-address: 0.0.0.0'

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

CLAassistant commented 9 months ago

CLA assistant check
All committers have signed the CLA.

deric commented 9 months ago

Looks good, it would be nice to have some tests for this feature.

treydock commented 8 months ago

@deric I've added some unit tests

deric commented 8 months ago

@treydock Thanks, looks good. The centos failure seems to be unrelated.