search

puppetlabs / puppetlabs-mysql

MySQL Puppet Module / Manifests + Types & Providers
Apache License 2.0
380 stars 792 forks source link

do not emit other ssl directives when ssl = false #1513

Closed kjetilho closed 1 year ago

kjetilho commented 1 year ago

This is needed for newer versions of MariaDB, see issue #1509

LukasAud commented 1 year ago

Hi, @kjetilho. Thanks for your contribution. We are currently investigating the issue you are trying to address. Unfortunately, it doesnt seem like our test cases cover this scenario so we will need to investigate a bit further to ensure that your PR does not have any unexpected side effect. Meanwhile, could you implement a test case for your change?

kjetilho commented 1 year ago

something like the above?

LukasAud commented 1 year ago

Yes, that should be enough. Thanks for your contribution. We will merge as soon as we finish testing it on our side.