search

puppetlabs / puppetlabs-mysql

MySQL Puppet Module / Manifests + Types & Providers
Apache License 2.0
380 stars 792 forks source link

Allow to set and run backups using another user via cron #1531

Open deepak7340 opened 1 year ago

CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Deepak Tiwari seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

puppet-community-rangefinder[bot] commented 1 year ago

mysql::backup::mysqlbackup is a class

that may have no external impact to Forge modules.

mysql::backup::mysqldump is a class

that may have no external impact to Forge modules.

mysql::backup::xtrabackup is a class

that may have no external impact to Forge modules.

mysql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match): * [edestecd-mariadb](https://github.com/edestecd/puppet-mariadb.git) * [brucem-ezpublish](https://github.com/brucem/puppet-ezpublish.git)
Breaking changes to this file MAY impact these 1 modules (near match): * [willdurand-bazinga](https://forge.puppet.com/willdurand/bazinga)

mysql::server::backup is a class

Breaking changes to this file WILL impact these 4 modules (exact match): * [thbe-bareos](https://github.com/thbe/puppet-bareos.git) * [thbe-bacula](https://github.com/thbe/puppet-bacula.git) * [dmcnicks-sympa](https://github.com/dmcnicks/dmcnicks-sympa.git) * [mightp-librenms](https://github.com/magnuslarsen/librenms-puppet)

This module is declared in 140 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

david22swan commented 1 year ago

Functionality looks good on a first pass but would need some test's to back it up before we can merge it in.

deepak7340 commented 1 year ago

Hi @david22swan can you please merge this since we need to deploy this in our server.

LukasAud commented 1 year ago

Hi @deepak7340, as @david22swan previously mentioned, the code looks good but we would need you to create some tests to back it up for the future. Additionally, it would be great if you could create a better description for the PR.

It also looks like there are some conflicts that must be resolved before CI can start running.

If you can address those few blockers, we would be happy to review/merge this.