puppetlabs / puppetlabs-mysql

MySQL Puppet Module / Manifests + Types & Providers
Apache License 2.0
380 stars 796 forks source link

allow tls_options to be of String #1540

Open janit42 opened 1 year ago

janit42 commented 1 year ago

the type of $tls_options has recently been changed to Array in 5131e0f806 while the code in lib/puppet/type/mysql_user.rb is able to work with it as an Array or a String.

This change allows $tls_options to by a String in addition to Array, which re-establishes compatibility with other modules, like puppet-icinga

Fixes https://github.com/puppetlabs/puppetlabs-mysql/issues/1539

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

puppet-community-rangefinder[bot] commented 1 year ago

mysql::db is a type

Breaking changes to this file WILL impact these 68 modules (exact match): * [wdijkerman-zabbix](https://github.com/dj-wasabi/puppet-zabbix.git) * [autostructure-artifactory](https://github.com/autostructure/artifactory.git) * [puppet-zabbix](https://github.com/voxpupuli/puppet-zabbix.git) * [razorsedge-cloudera](https://github.com/razorsedge/puppet-cloudera.git) * [sensson-powerdns](https://github.com/sensson/puppet-powerdns) * [treydock-keycloak](https://github.com/treydock/puppet-module-keycloak) * [puppetlabs-bacula](http://github.com/puppetlabs/puppetlabs-bacula) * [jsnshrmn-twlight](https://github.com/WikipediaLibrary/twlight_puppet) * [cesnet-site_hadoop](https://github.com/MetaCenterCloudPuppet/cesnet-site_hadoop) * [geoffwilliams-r_profile](https://github.com/GeoffWilliams/r_profile) * [maxadamo-galera_proxysql](https://gitlab.com/maxadamo/galera_proxysql) * [sgnl05-racktables](https://github.com/sgnl05/sgnl05-racktables.git) * [shoekstra-owncloud](https://github.com/shoekstra/puppet-owncloud.git) * [binford2k-drupal](https://github.com/binford2k/binford2k-drupal) * [mmitchell-puppetlabs_ironic](https://github.com/stackforge/puppet-ironic) * [oris-appserver](https://bitbucket.org/oris/env-puppet-module-appserver) * [brucem-ezpublish](https://github.com/brucem/puppet-ezpublish.git) * [rharrison-bacula](http://github.com/rharrison10/rharrison-bacula) * [wyrie-nagiosql](https://bitbucket.org/wyrie/puppet-nagiosql/src) * [desalvo-bacula](https://github.com/desalvo/puppet-bacula) * [openstack-monasca](https://opendev.org/openstack/puppet-monasca.git) * [hgkamath-owncloud](https://github.com/hgkamath/puppet-owncloud) * [ULHPC-slurm](https://github.com/ULHPC/puppet-slurm) * [bramwelt-patchwork](https://github.com/bramwelt/puppet-patchwork) * [blackknight36-bacula](https://github.com/blackknight36/puppet-bacula.git) * [martasd-mediawiki](https://github.com/martasd/puppet-mediawiki.git) * [alkivi-zabbix](https://github.com/alkivi-sas/puppet-zabbix) * [cirrax-postfixadmin](https://github.com/cirrax/puppet-postfixadmin) * [SchnWalter-happydev](https://github.com/devgateway/happy-deployer/tree/master/puppet/modules/happydev) * [fiddyspence-zabbix](https://github.com/fiddyspence/puppet-zabbix) * [aimonb-nexusis_mediawiki](https://github.com/NexusIS/puppet-mediawiki.git) * [jefferyb-kualicoeus](https://github.com/jefferyb/kualicoeus) * [alkivi-owncloud](https://github.com/alkivi-sas/puppet-owncloud) * [lboynton-gitlab](https://github.com/lboynton/puppet-gitlab) * [ccaum-autoami](https://github.com/ccaum/puppet-autoami) * [wyrie-snmptt](https://bitbucket.org/wyrie/puppet-snmptt/src) * [firefield-firefield](https://github.com/firefield/basic-rails-server.git) * [forj-openfire](https://github.com/forj-oss/puppet-openfire) * [cnwr-cacti](https://github.com/cnwrinc/cnwr-cacti) * [leonardothibes-usvn](https://github.com/leonardothibes/puppet-usvn.git) * [aimonb-nexusis_gerrit](https://forge.puppet.com/aimonb/nexusis_gerrit) * [dsestero-sonarqube](https://github.com/dsestero/sonarqube.git) * [stesie-gluon](https://github.com/ffansbach/gluon-puppet) * [hexmode-mediawiki](https://github.com/hexmode/puppet-mediawiki.git) * [tscopp-jss](https://github.com/tscopp/puppet-jss/issues) * [dmcnicks-sympa](https://github.com/dmcnicks/dmcnicks-sympa.git) * [marcdeop-ratticdb](https://github.com/marcdeop/ratticdb) * [othalla-nextcloud](https://github.com/othalla/puppet-nextcloud.git) * [icann-opendnssec](https://github.com/icann-dns/puppet-opendnssec) * [alisio-opensips](https://github.com/alisio/opensips.git) * [factorit-jasperreports_server](https://github.com/jbbrunsveld/jasperreports_server) * [martialblog-limesurvey](https://github.com/martialblog/puppet-limesurvey) * [treydock-xdmod](https://github.com/treydock/puppet-module-xdmod) * [monkygames-beansbooks](https://bitbucket.org/monkygames/puppet-beansbooks.git) * [akisakye-matomo](https://github.com/akisakye/matomo.git) * [infnpd-ocpattrauth](https://baltig.infn.it/andreett/puppet-ocp-attribute-authority) * [mricon-bugzilla](https://github.com/mricon/puppet-bugzilla) * [eelcomaljaars-friendica](https://devtools.maljaars-it.nl/opensource/puppet-friendica.git) * [fervid-artifactory](https://github.com/fervidus/artifactory.git) * [treydock-slurm](https://github.com/treydock/puppet-slurm) * [samuelson-custom_webapp](https://github.com/samuelson/samuelson-custom_webapp) * [cirrax-roundcube](https://github.com/cirrax/puppet-roundcube) * [bodgit-wordpress](https://github.com/bodgit/puppet-wordpress) * [alisio-opensipscp](https://github.com/alisio/opensipscp) * [mightp-librenms](https://github.com/magnuslarsen/librenms-puppet) * [benjaminrobertson-observium](https://github.com/benjamin-robertson/observium) * [qroac-isp3node](https://github.com/qroac/puppet-ispconfig) * [lsst-ccs_database](https://github.com/lsst-it/puppet-ccs_database)
Breaking changes to this file MAY impact these 16 modules (near match): * [lcgdm-dmlite](https://gitlab.cern.ch/lcgdm/dmlite) * [lcgdm-lcgdm](https://github.com/cern-it-sdc-id/puppet-lcgdm) * [icinga-icinga](https://github.com/icinga/puppet-icinga) * [cesnet-hive](https://github.com/MetaCenterCloudPuppet/cesnet-hive) * [tykeal-gerrit](https://github.com/tykeal/puppet-gerrit.git) * [cesnet-oozie](https://github.com/MetaCenterCloudPuppet/cesnet-oozie) * [echoes-wrappers](https://github.com/echoes-tech/puppet-wrappers) * [jtopjian-cubbystack](https://github.com/jtopjian/puppet-cubbystack) * [erwbgy-wso2](https://github.com/erwbgy/puppet-wso2.git) * [soli-wrappers](https://github.com/solution-libre/puppet-wrappers) * [mwils-complete_wordpress](https://forge.puppet.com/mwils/complete_wordpress) * [devopera-domysqldb](https://github.com/devopera/puppet-domysqldb) * [halyard-boxen](https://github.com/halyard/puppet-boxen) * [rspiak-racktables](https://github.com/sgnl05/sgnl05-racktables) * [abaranov-sqlgrey](https://github.com/spacedog/puppet-sqlgrey) * [kclnmssys-sympa](https://github.com/kcl-nmssys/puppet-sympa)

This module is declared in 140 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

bastelfreak commented 8 months ago

@janit42 please rebase against main to get rid of the merge commit.

janit42 commented 7 months ago

@janit42 please rebase against main to get rid of the merge commit.

thanks for the heads-up @bastelfreak ! Anything else I can do for now?

bastelfreak commented 7 months ago

@janit42 can you maybe add a unit test for it?