puppetlabs / puppetlabs-mysql

MySQL Puppet Module / Manifests + Types & Providers
Apache License 2.0
380 stars 792 forks source link

Sensitive parameter support broken of mysql::password #1563

Closed cruelsmith closed 1 year ago

cruelsmith commented 1 year ago

Describe the Bug

The puppet function mysql::password does not allow a second parameter anymore to toggle the return value to be a sensitive. Instead the puppet run fails with a wrong number of arguments message.

This issue has been introduced with #1557 https://github.com/puppetlabs/puppetlabs-mysql/commit/effc6846e132fe0c41d279cb1ff03e989d4e3cb7#diff-f63c8340e97cb15646da94767358abc703a41ba144fa217d9585e00b8a04b289L22-R22

Expected Behavior

Steps to Reproduce

Environment

Additional Context

Note: That the rspec test for this case is currently simply skipped instead of testing it. This needs to also be fixed via the same PR. https://github.com/puppetlabs/puppetlabs-mysql/blob/00255c75fa8cd7cf112facf77c844535fe6a71fc/spec/functions/mysql_password_spec.rb#L26-L30