search

puppetlabs / puppetlabs-mysql

MySQL Puppet Module / Manifests + Types & Providers
Apache License 2.0
380 stars 792 forks source link

Fix broken sensitive parameter for mysql::password #1564

Closed cruelsmith closed 1 year ago

cruelsmith commented 1 year ago

Revert broken change of #1557 and fixes the spec test for it by removing the skip.

Fixes #1563

puppet-community-rangefinder[bot] commented 1 year ago

mysql::password is a function

Breaking changes to this file WILL impact these 7 modules (exact match): * [qroac-isp3node](https://github.com/qroac/puppet-ispconfig) * [edestecd-mariadb](https://github.com/edestecd/puppet-mariadb.git) * [cnafsd-storm](https://github.com/italiangrid/storm-puppet-module) * [openstack-monasca](https://opendev.org/openstack/puppet-monasca.git) * [openstack-congress](https://github.com/openstack/puppet-congress.git) * [openstack-tripleo](https://opendev.org/openstack/puppet-tripleo.git) * [openstack-openstacklib](https://opendev.org/openstack/puppet-openstacklib.git)
Breaking changes to this file MAY impact these 1 modules (near match): * [icinga-icinga](https://github.com/icinga/puppet-icinga)

mysql_password is a function

Breaking changes to this file WILL impact these 17 modules (exact match): * [mmitchell-puppetlabs_ironic](https://github.com/stackforge/puppet-ironic) * [dmexe-rails](http://github.com/dima-exe/puppet-rails) * [nubevps-wordpress](https://forge.puppetlabs.com/nubevps-wordpress/nubevps-wordpress) * [puppetlabs-wordpress_app](https://github.com/puppetlabs/puppetlabs-wordpress_app) * [tscopp-jss](https://github.com/tscopp/puppet-jss/issues) * [infnpd-creamce](https://github.com/italiangrid/puppet-creamce) * [maxadamo-galera_maxscale](https://github.com/maxadamo/galera_maxscale) * [mikegleasonjr-wordpress](https://github.com/mikegleasonjr/puppet-wordpress.git) * [hunner-wordpress](https://github.com/hunner/puppet-wordpress) * [neillturner-wordpress](https://github.com/neillturner/puppet-wordpress) * [ULHPC-slurm](https://github.com/ULHPC/puppet-slurm) * [hfm-mha](https://github.com/hfm/puppet-mha.git) * [johanek-redmine](https://github.com/johanek/johanek-redmine) * [fraenki-galera](https://github.com/fraenki/puppet-galera) * [maxadamo-galera_proxysql](https://gitlab.com/maxadamo/galera_proxysql) * [puppet-zabbix](https://github.com/voxpupuli/puppet-zabbix.git) * [wdijkerman-zabbix](https://github.com/dj-wasabi/puppet-zabbix.git)
Breaking changes to this file MAY impact these 26 modules (near match): * [brainfinger-dukesbank](https://github.com/teyo/brainfinger-dukesbank.git) * [reidmv-pe_console](https://github.com/reidmv/puppet-module-pe_console) * [narasimhasv-glance](https://forge.puppet.com/narasimhasv/glance) * [dmexe-deploy](http://github.com/dima-exe/puppet-deploy) * [eshamow-pe_cert_auth](https://forge.puppet.com/eshamow/pe_cert_auth) * [alanpetersen-moodle](https://github.com/alanpetersen/puppet-moodle.git) * [lcgdm-voms](https://gitlab.cern.ch/ai/it-puppet-module-voms) * [devopera-domysqldb](https://github.com/devopera/puppet-domysqldb) * [jtopjian-cubbystack](https://github.com/jtopjian/puppet-cubbystack) * [ploperations-puppet](https://github.com/puppetlabs-operations/puppet-puppet) * [vshn-uhosting](https://github.com/vshn/uhosting) * [Aethylred-puppetdashboard](https://github.com/Aethylred/puppet-puppetdashboard) * [vStone-percona](https://github.com/vStone/puppet-percona) * [gousto-mysql](https://github.com/Gousto/puppetlabs-mysql.git) * [midonet-neutron](https://github.com/midonet/puppet-neutron.git) * [stackforge-glance](https://github.com/openstack/puppet-glance.git) * [stackforge-neutron](https://github.com/openstack/puppet-neutron.git) * [stackforge-heat](https://github.com/openstack/puppet-heat.git) * [stackforge-nova](https://github.com/openstack/puppet-nova.git) * [stackforge-cinder](https://github.com/openstack/puppet-cinder.git) * [stackforge-ceilometer](https://github.com/openstack/puppet-ceilometer.git) * [stackforge-keystone](https://github.com/openstack/puppet-keystone.git) * [openstack-tuskar](https://github.com/openstack/puppet-tuskar.git) * [lcgdm-lcgdm](https://github.com/cern-it-sdc-id/puppet-lcgdm) * [lcgdm-dmlite](https://gitlab.cern.ch/lcgdm/dmlite) * [adam8723-mysql](https://github.com/puppetlabs/puppetlabs-mysql.git)

This module is declared in 140 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

cruelsmith commented 1 year ago

Sry @b4ldr could you check it please once again? I missed the RuboCop ignore rule since i just run the spec test locally.