search

puppetlabs / puppetlabs-mysql

MySQL Puppet Module / Manifests + Types & Providers
Apache License 2.0
380 stars 792 forks source link

$includedir is not purged when provider = MariaDB #1590

Open bschonec opened 1 year ago

bschonec commented 1 year ago

Describe the Bug

The $includedir (/etc/my.cnf.d) is not purged when the provider is MariaDB because $includedir is undefined.

Expected Behavior

$includedir to be purged of extraneous files.

Steps to Reproduce

Steps to reproduce the behavior:

  1. ensure $mysql::server::purge_conf_dir: true
  2. Use this module to install MariaDB on RHEL7 or newer.
  3. Observe that $includedir is not purged of extraneous files

Environment

Additional Context

Why ISN'T $includedir defined?

bschonec commented 1 year ago

Why is special consideration given to the mariadb provider and its parent directly as shown here? There's no purge/recurse facility for the directory resource.

https://github.com/bschonec/puppetlabs-mysql/tree/maraidb_purge_includedir