search

puppetlabs / puppetlabs-mysql

MySQL Puppet Module / Manifests + Types & Providers
Apache License 2.0
380 stars 790 forks source link

Add support for Mariadb 11.x #1626

Open OxCom opened 5 months ago

OxCom commented 5 months ago

From MariaDB 10.4 we have deprecation notice that mysql* names will be removed. See: JIRA ticket

Resolve #1580

Manually verified un Ubuntu 22.04 and MariaDB 11.x.

Deprecation notice examples:

mysql: Deprecated program name. It will be removed in a future release, use '/usr/bin/mariadb' instead.
mysqld: Deprecated program name. It will be removed in a future release, use '/usr/sbin/mariadbd' instead
mysqladmin: Deprecated program name. It will be removed in a future release, use '/usr/bin/mariadb-admin' instead
CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

alnet commented 4 months ago

+1 to wanting this merged. Thank you folks!

nlegaillart-dri commented 1 month ago

Hi, when trying this PR with MariaDB 11.4, Puppet Agent hangs on first run with Error: Could not run: stack level too deep. This seems to be caused by first method self.mysql_raw() because it works when I comment it out. Once the first run has passed, it also works with this method restored.

Does anybody noticed the same behaviour?

nlegaillart-dri commented 3 weeks ago

Hi, when trying this PR with MariaDB 11.4, Puppet Agent hangs on first run with Error: Could not run: stack level too deep. This seems to be caused by first method self.mysql_raw() because it works when I comment it out. Once the first run has passed, it also works with this method restored.

Does anybody noticed the same behaviour?

Some news about the Error: Could not run: stack level too deep: this append on a fresh install, when there is no fact defined and no mysql/mariadb binary installed on the platform. In this case mysqld_version_string would equal nil, preventing scan()method to work properly (just a thought, I am no developer)