puppetlabs / puppetlabs-node_manager

Create and manage PE node groups as resources.
Apache License 2.0
10 stars 21 forks source link

New face #19

Closed WhatsARanjit closed 7 years ago

WhatsARanjit commented 7 years ago

Running through the endpoints on https://docs.puppet.com/pe/latest/nc_index.html

Considerations

WhatsARanjit commented 7 years ago

Demoed for TSEs. They provided some feedback:

NOTE: The hashify_group_array reorders the JSON response so that it is not useable as a request's payload. An export action would have to not do this. That is, this format won't work:

puppet node_manager groups --all --render-as json

WhatsARanjit commented 7 years ago

Ditched the --all flag. Refactored so if you don't supply an argument to the query, it will list all. For example:

Revamped some of the returns so querying a single value would return pretty JSON and query multiple values would return a list of keys. Also added some better error handling based on HTTP codes. PR lives here: https://github.com/WhatsARanjit/prosvcs-node_manager/pull/21

WhatsARanjit commented 7 years ago

Merged.