search

puppetlabs / puppetlabs-node_manager

Create and manage PE node groups as resources.
Apache License 2.0
10 stars 21 forks source link

Show errors when unable to create node group #35

Closed reidmv closed 6 years ago

reidmv commented 6 years ago

Currently, the specifics of a failure to create a node group are only logged at debug. This kind of error should be surfaced to the user so that if something goes wrong, it's apparent what it was.

This commit makes API create errors print, should errors occur.

WhatsARanjit commented 6 years ago

@reidmv Looking at this, I think I'd still prefer to put raw output in debug only. But maybe the error message could be a more friendly version like:

Classifier returned a $type error with the message '$message'

...or something.

WhatsARanjit commented 6 years ago

Rethinking in #39.