search

puppetlabs / puppetlabs-node_manager

Create and manage PE node groups as resources.
Apache License 2.0
10 stars 21 forks source link

reimplement do_https() using HttpPool #56

Open kreeuwijk opened 4 years ago

kreeuwijk commented 4 years ago

This reimplements the do_https() method, moving away from Net::HTTP, in favor of Puppet::Network::HttpPool.connection. This is because Net::HTTP gets emulated by JRuby in Puppetserver, and fails to connect via SSL, citing a handshake_failure. Instead, this uses Puppet's own HTTP client, which works correctly in both Puppet Agent and Puppetserver. This change makes node_groups() work correctly again on newer PE versions that enforce TLS 1.2.

kreeuwijk commented 4 years ago

@WhatsARanjit ^^

16c7x commented 4 years ago

Hit this problem on 2019.7.0, switching over to @kreeuwijk 's fork fixed node_groups() for me.

CLAassistant commented 3 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Kevin Reeuwijk seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

timidri commented 2 months ago

@Ramesh7 @jonathannewman Is this PR still viable or has it been superseded and can it be closed?

jonathannewman commented 2 months ago

The mechanism used is now deprecated in favor of Http::Client https://www.rubydoc.info/gems/puppet/Puppet/Network/HttpPool

so it will need to be updated.

timidri commented 2 months ago

The mechanism used is now deprecated in favor of Http::Client https://www.rubydoc.info/gems/puppet/Puppet/Network/HttpPool

so it will need to be updated.

But do we need to update this or has the original problem been solved?

jonathannewman commented 2 months ago

But do we need to update this or has the original problem been solved?

It is a performance optimization. Ideally it would be updated, but it will function without it.

bastelfreak commented 3 weeks ago

@kreeuwijk hi! Any chance you can rebase this?